Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement :GoFillStruct #1443

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Implement :GoFillStruct #1443

merged 1 commit into from
Sep 18, 2017

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Sep 13, 2017

Just the bare basics; fixes #1425.

@arp242 arp242 changed the title [WIP] Implement :GoFillStruct Implement :GoFillStruct Sep 15, 2017
@arp242
Copy link
Contributor Author

arp242 commented Sep 15, 2017

This is now done. It depends on #1456, otherwise errors don't look very good.

I haven't implemented the proposed :GoCode from #1445; can do that in a future PR, after we've decided how this will look.

@fatih
Copy link
Owner

fatih commented Sep 15, 2017

This looks good. Wish it could work when you put it everywhere on the line instead of putting it on the struct literal. I think this is something @davidrjenni can fix though. Adding him if he can chime on that.

@fatih
Copy link
Owner

fatih commented Sep 15, 2017

@Carpetsmoker can you add docs please for this

endfor

" Out with the old ...
exe 'normal! ' . l:json['start'] . 'gov' . l:json['end'] . 'gox'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is gov and gox here?

Copy link
Contributor Author

@arp242 arp242 Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's:

  • 123go – go to offset.
  • v132 – go to offset.
  • x – delete.

@arp242 arp242 merged commit 40bdb6a into fatih:master Sep 18, 2017
@arp242 arp242 deleted the fillstruct branch September 18, 2017 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature-request: Initialize struct instance command
2 participants